-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that v:resource.record is not to be used as generic record l… #1912
Conversation
@@ -8,8 +8,11 @@ resource.record ViewHelper `<vhs:resource.record>` | |||
================================================== | |||
|
|||
|
|||
Generic FAL resource ViewHelper | |||
Generic FAL resource ViewHelper. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files in Documentation/ViewHelpers are auto-generated whenever a ViewHelper class file changes - these changes would be overwritten by that automation. The other change is fine (except the .rst file doesn't need to be changed, that's automated), but this one for v:resource.record needs to be added in the RecordViewHelper directly.
Fixed. |
Thanks! Reported problems with code style are totally unrelated, caused by yet another phpstan update upstream which again changed which issues are reported - this happens so damn frequently, I should probably nail the phpstan dependency to a specific version... |
I once ranted on the pear-dev mailing list about each php_codesniffer update adding new rules that my code did not follow. It turned out I was using phpcs wrong and ran it without a coding style and all new rules were used. The correct way was to choose a coding style with a hard list of rules, and stick to it. |
Could be. Right now I'm using phpstan with just a level, which definitely changes the detection rules very frequently - PHPCS is being used with a standard, PSR2, which hasn't changed. |
If you pull |
I don't see the "edits from maintainers" option anywhere here :(
and I am hosting the vhs fork at my company's org account, not my personal one. |
That makes sense. No worries, we can work with this as long as you're OK with me asking you to rebase or make minor changes yourself every now and then! |
…oader
Related: #960
It bit me today when using it in the backend preview with a disabled/hidden record :(